Fix for CVE-2024-55587: Prevent Directory Traversal in ZIP Extraction #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request from 'feature_master_MVA8' to 'master'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Issue Addressed
This PR mitigates the security vulnerability CVE-2024-55587, which allows directory traversal attacks when extracting ZIP files using python-libarchive.
Fix Implemented:
Sanitized Filenames:
Introduced sanitize_filename() in zip.py to remove malicious path components like ../ and absolute paths.
Ensures extracted files remain within the intended directory.
Updated extract() and extractall():
Applied sanitize_filename() to prevent unsafe file extractions.
Raised ValueError if an unsafe path is detected.
Added Test Cases:
Unit tests in test_zip.py to validate:
Prevents directory traversal attacks, mitigating the security risk.
Ensures backward compatibility with existing safe extractions.
Improves overall security of ZipFile extraction methods.