[knx] fix DPT 3.007 for non -control channels (#162)

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
smarthomej · Jul 18, 2021 · d59fa20 · d59fa20
1 parent db2422e
commit d59fa20
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/....binding.knx/src/main/java/org/smarthomej/binding/knx/internal/dpt/KNXCoreTypeMapper.java b/....binding.knx/src/main/java/org/smarthomej/binding/knx/internal/dpt/KNXCoreTypeMapper.java
@@ -322,15 +322,16 @@ private KNXCoreTypeMapper() {
                     DPTXlator3BitControlled translator3BitControlled = (DPTXlator3BitControlled) translator;
                     if (translator3BitControlled.getStepCode() == 0) {
                         LOGGER.debug("convertRawDataToType: KNX DPT_Control_Dimming: break received.");
-                        return UnDefType.UNDEF;
+                        return UnDefType.NULL;
                     }
                     switch (m.group("sub")) {
-                        case "7":
+                        case "007":
                             return translator3BitControlled.getControlBit() ? IncreaseDecreaseType.INCREASE
                                     : IncreaseDecreaseType.DECREASE;
-                        case "8":
+                        case "008":
                             return translator3BitControlled.getControlBit() ? UpDownType.DOWN : UpDownType.UP;
                     }
+                    break;
                 case "18":
                     DPTXlatorSceneControl translatorSceneControl = (DPTXlatorSceneControl) translator;
                     int decimalValue = translatorSceneControl.getSceneNumber();

diff --git a/...ing.knx/src/main/java/org/smarthomej/binding/knx/internal/handler/DeviceThingHandler.java b/...ing.knx/src/main/java/org/smarthomej/binding/knx/internal/handler/DeviceThingHandler.java
@@ -357,7 +357,7 @@ private void processDataReceived(GroupAddress destination, byte[] asdu, InboundS
                     }
                 }
             } else {
-                if (value instanceof State) {
+                if (value instanceof State && !(value instanceof UnDefType)) {
                     updateState(knxChannel.getChannelUID(), (State) value);
                 }
             }