Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] add support for DPT 22.xxxx #74

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[knx] add support for DPT 22.xxxx #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ....binding.knx/src/main/java/org/smarthomej/binding/knx/internal/dpt/KNXCoreTypeMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,17 @@ public KNXCoreTypeMapper() {
/** Exceptions Datapoint Types, Main number 21 */
// Example since calimero 2.4: dptTypeMap.put(DptXlator8BitSet.DptGeneralStatus.getID(), StringType.class);

/**
* MainType: 22
* unsupported: 22.100: DHW Controller Status
* 22.101: RHCC Status (enumeration)
* unsupported: 22.102: HVAC combined status
* unsupported: 22.103: RTC status
* 22.1000: KNX medium (enumeration)
* unsupported: 22.1010: 16 channel activation
*/
dptMainTypeMap.put(22, StringType.class);

/**
* MainType: 28
* 28.001: UTF-8
Expand Down Expand Up @@ -706,6 +717,10 @@ public KNXCoreTypeMapper() {
case 8:
return translatorBoolean.getValueBoolean() ? UpDownType.DOWN : UpDownType.UP;
case 9:
// This is wrong. It should be true -> CLOSE, false -> OPEN, but can't be fixed without
// breaking
// a lot of working installations. The documentation has been updated to reflect that. /
// @J-N-K
return translatorBoolean.getValueBoolean() ? OpenClosedType.OPEN : OpenClosedType.CLOSED;
case 10:
return translatorBoolean.getValueBoolean() ? StopMoveType.MOVE : StopMoveType.STOP;
Expand Down