feat: simplify data view model #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buehler
pushed a commit
that referenced
this pull request
Mar 18, 2024
# [2.0.0](v1.2.1...v2.0.0) (2024-03-18) ### Features * simplify data view model ([#5](#5)) ([fad3176](fad3176)) ### BREAKING CHANGES * This removes the complex initialization logic of the `DataViewModel<T>`. Instead of using the `initializeData` method, now the constructor of the view model requires some form of initial data. This requires developers to explicitely define nullable types and allows the `data` field to be initialized in all cases. To migrate, remove all `initializeData` calls and provide the constructor with some default data. It is still possible to load data asynchronously, by overwriting the `initialize` method and fetching data there. One is responsible to call `super.initialize` in error cases. * This simplifies the routable and dialog config by removing the `RouteBuilder.custom` variant. Basically, to use a custom page route builder, just use the provided property (`pageRouteBuilder`) and do not set the `routeBuilder` property. If the page route builder is provided, the route builder property is ignored.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This removes the complex initialization
logic of the
DataViewModel<T>. Instead of using theinitializeDatamethod, now the constructor of the view modelrequires some form of initial data. This requires developers to
explicitely define nullable types and allows the
datafield to beinitialized in all cases. To migrate, remove all
initializeDatacallsand provide the constructor with some default data. It is still possible
to load data asynchronously, by overwriting the
initializemethod andfetching data there. One is responsible to call
super.initializein error cases.BREAKING CHANGE: This simplifies the routable and dialog config by
removing the
RouteBuilder.customvariant. Basically, to use a custompage route builder, just use the provided property (
pageRouteBuilder)and do not set the
routeBuilderproperty. If the page route builder is provided,the route builder property is ignored.