You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
makeAllOf uses the last type in allOf as the class to instantiate. This is a bit incorrect as then you cannot do X instanceof T for allOf: T, K. Also the types of the fields suffer from this issue.
Instead we should I guess merge the type definitions recursively and set the instanceof manually to the new object with Symbol.hasInstance
makeAllOf uses the last type in allOf as the class to instantiate. This is a bit incorrect as then you cannot do
X instanceof T
forallOf: T, K
. Also the types of the fields suffer from this issue.Instead we should I guess merge the type definitions recursively and set the instanceof manually to the new object with Symbol.hasInstance
see smartlyio/oats-runtime#57 for related discussion on dangers of classes
The text was updated successfully, but these errors were encountered: