Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VULCAN-2933: Own action with typescript build #4

Merged
merged 11 commits into from
Mar 22, 2023
Merged

VULCAN-2933: Own action with typescript build #4

merged 11 commits into from
Mar 22, 2023

Conversation

cmaster11
Copy link
Contributor

@cmaster11 cmaster11 commented Mar 22, 2023 •
edited
Loading

This PR is a port of https://github.com/Khan/pull-request-comment-trigger to our own action.

Test trigger: #hello #deploy

P.s. The little rocket below here means that the deploy keyword triggered a reaction!

@swarmia
Copy link

swarmia bot commented Mar 22, 2023

✅  Linked to VULCAN-2933 · Get rid of khan/pull-request-comment-trigger
➡️  Part of Story VULCAN-2899 · Get rid of the rest of set-output and set-state usage

1 similar comment
@swarmia
Copy link

swarmia bot commented Mar 22, 2023

✅  Linked to VULCAN-2933 · Get rid of khan/pull-request-comment-trigger
➡️  Part of Story VULCAN-2899 · Get rid of the rest of set-output and set-state usage

@cmaster11
Copy link
Contributor Author

#hello

cmaster11 added 2 commits March 22, 2023 13:03
@cmaster11 cmaster11 marked this pull request as ready for review March 22, 2023 11:04
@cmaster11 cmaster11 requested a review from a team March 22, 2023 11:04
fisherking
fisherking approved these changes Mar 22, 2023
View reviewed changes
Copy link

@fisherking fisherking left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to make this repo accessible by github actions in other org repos, because it's private

@cmaster11 cmaster11 merged commit 64daa3c into master Mar 22, 2023
@cmaster11
Copy link
Contributor Author

I guess we need to make this accessible by github actions in other org repos, because it's private

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherking fisherking fisherking approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaster11 @fisherking