Add new sensor types #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have an integration test based on ros launch testing. Both tests are similar and hence we could just stick to one.
The binaries include a user_interface directory which should be now directly used. Updated Readme to the new changes.
Also update the smart access binary release to be used by the driver
|
The binaries are now available and thus the build-tests are passing. PR is ready. |
smartBUILDBOT
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33 Follows the issue. Along with new sensor types, extra commands and parameters have been added to interface with the sensors.
Note: the build would not be passed as we require libs for the new interfaces which are not part of the old script.