#6 can integration #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate param files for adapters and sensors. Callbacks for CAN interface included and older port callbacks adopted to new port interfaces. Launch file adopted to launch node with multiple parameter files. Smart access configs adapoted to offer CAN and port based communication. New params included for the node to be declared.
Add instructions on how to set-up can and ethernet interfaces. Lists new adapter and sensor parameters for node configuration. The simulators are updated to work with the new interface and docker environment respectively. The tests for the node have been updated also.
Update release version, reduce port stream time and update comment in test
|
The PR is ready to be reviewed. |
smartBUILDBOT
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows the issue #6 and requests for CAN support. The PR allows all radar sensors along with all the user-interfaces to be connected with either ethernet, CAN or both. The PR requires new release and the binaries are not yet available hence the build would not pass.