Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Add the suite of Mock API serialization tests to the C# SDK. #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

armstnp
Copy link

@armstnp armstnp commented Jun 16, 2018

There were five serialization tests that failed in various ways, and are thus currently configured to be ignored:

BulkFailure
The failure for this one is pretty mysterious, as the JSON deserializer seems to expect more content, but it's unclear as to which content it expects and isn't seeing.

Predecessor
This has two points of failure: AddRows should support query parameters (include specifically, here), but does not; and the generic ObjectValue type is not deserialized from the response, currently. This test will need to be unignored and its assertions uncommented to be considered fully active once fixed.

Sheet Settings
The Schedule object's 'Non-working days' field expects day-level granularity dates ('2018-10-10', e.g.), but the SDK always serializes it to full date-times.

Update Request
The Schedule object's lastSentAt and nextSendAt fields ought to be optional, but instead are mandatory and sent with every request, instead of only being received by a Schedule response.

User
The profileImage field expects a response ID named imageId, not id, and so deserialization fails.

@armstnp
Copy link
Author

armstnp commented Jun 22, 2018

Added tests for 'Change Agent' and 'Assume User' headers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant