Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/models): property name to match api #33

Open
wants to merge 2 commits into
base: mainline
Choose a base branch
from

Conversation

pratik136
Copy link
Contributor

There was a mismatch in the property names between the model within the SDK and the Smartsheet API.

This is the Smartsheet API object definition: https://smartsheet.redoc.ly/tag/automationRulesObjects#section/AutomationAction-Object

@pratik136 pratik136 force-pushed the fix/32-trying-to-update-an-automationrule-objec branch from 89675f6 to 0620965 Compare July 21, 2023 02:24
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [3.0.1] - 2023-07-21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainline is no longer 3.0.1

mainline contains a beta fix so it has a higher minor version, I think

Copy link
Contributor

@timothodge timothodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus the comment about the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants