fix(security): update okhttp3 to get ridof vulnerabilities CVE-2023-3635 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This references to: #113 - Update okhttp Library to Address CVE-2021-0341 and CVE-2023-3635 #113 |
apederson94
approved these changes
Feb 1, 2025
|
I approved this MR, but you'll need to rebase as well |
|
@zromano should we be expecting the integration tests to fail like this? |
|
@apederson94 Yeah, they will fail until merging for non-members due to a permissions issue. This has been something I mean to look into, but it's mostly members creating PRs, so I hadn't gotten around to it. Also thank you @Superkunair for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2021-0341 (okhttp):
Description: This vulnerability in OkHostnameVerifier.java could allow a certificate for the wrong domain to be accepted due to improperly used cryptography. This can lead to remote information disclosure without requiring additional execution privileges1.
Affected Versions: All versions of okhttp v3.x and v4.x are affected.
CVE-2023-3635 (okio):
Description: The GzipSource class does not handle exceptions properly when parsing a malformed gzip buffer. This can lead to a denial of service (DoS) when handling a crafted GZIP archive2.
Proposed Solution
Both issues are solved by updating okhttp to 4.12.0