Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update More Models to use Lombok - note Event::timestamp changed types #116

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

zromano
Copy link
Contributor

@zromano zromano commented Feb 5, 2025

Updates more classes to use Lombok. This is fairly similar to the other PRs, but there is one question on this one:

what should we do with Event::setEventTimestamp? It currently overrides the setter and has custom logic based on what is passed in.

# Conflicts:
#	src/main/java/com/smartsheet/api/models/Folder.java
#	src/main/java/com/smartsheet/api/models/Sight.java
#	src/main/java/com/smartsheet/api/models/Workspace.java
@zromano zromano changed the base branch from mainline to release/4.0 February 5, 2025 18:53
@zromano zromano changed the title Update More Models to use Lombok Update More Models to use Lombok - note Event::timestamp changed types Feb 5, 2025
@zromano zromano merged commit ac67224 into release/4.0 Feb 6, 2025
2 of 3 checks passed
@zromano zromano deleted the personal/zromano/add-more-lombok branch February 6, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant