Remove deprecated methods marked for removal in 4.0 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apederson94
reviewed
Feb 1, 2025
There was a problem hiding this comment.
None of the items in here were marked as for removal. What's the purpose of removing them?
There was a problem hiding this comment.
None of the items in here were marked as for removal. What's the purpose of removing them?
Comment on lines
-947
to
-949
| public UpdateRequest createUpdateRequest(long sheetId, MultiRowEmail email) throws SmartsheetException { | ||
| return this.createResource(SHEETS + "/" + sheetId + "/updaterequests", UpdateRequest.class, email); | ||
| } |
There was a problem hiding this comment.
This isn't marked as for removal. Why is it being removed?
There was a problem hiding this comment.
I don't remember anymore on this PR. I'm going to close it as it'd be quicker to just start over 😅
| String path = WORKSPACES + "/" + workspaceId + "/copy"; | ||
| Map<String, Object> parameters = new HashMap<>(); | ||
|
|
||
| parameters.put("include", QueryUtil.generateCommaSeparatedList(includes)); | ||
| parameters.put("skipRemap", QueryUtil.generateCommaSeparatedList(skipRemap)); | ||
| parameters.put("exclude", QueryUtil.generateCommaSeparatedList(excludes)); |
There was a problem hiding this comment.
Why is this being removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.