Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual examples #5

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add visual examples #5

merged 3 commits into from
Nov 3, 2023

Conversation

garcia-alejandro
Copy link
Collaborator

Pull Request: Add Explanation and Images for Various Documents

Description

This pull request includes updates to multiple documents for improved clarity and understanding. It adds explanations and images to help users better comprehend various concepts related to multisig setups and vault configurations.

UI Changes

  • Added explanatory content and images to the 'social-recovery.md' document to guide users on initiating fund spending through social recovery in a multisig setup.

Social Recovery

  • Updated the 'hold.md' document to provide a clearer example of vault configuration, along with an image illustrating the timelock condition.

Hodl

UX Changes

  • Added missing explanations for the second condition in the vault configuration example in the 'hold.md' document.

Please review and merge this pull request to enhance the user documentation.

…example

🖼️ ![image](https://github.com/smartvaults/smartvaults/assets/88842056/87b42cbc-4c7c-48c6-b924-82eae77651a4)

The vault configuration example demonstrates that to authorize a transaction, any combination of 2 out of the 3 keys (Thomas, Lee, or My Signer) is required. This means that you can use any pair of these keys to successfully spend the funds.
…improve clarity and understanding

🔍 chore(hold.md): add missing explanation for the second condition in the vault configuration example

🖼️ chore(hold.md): add image to visually represent the timelock condition in the vault configuration example
…funds spending via social recovery in multisig setup

The commit adds an explanation of how to initiate the spending of funds via social recovery in a multisig setup. It mentions that this can be done either by a designated signer or by following the social recovery path. It also states that this is only possible after the specified timelock duration has elapsed and requires the authorization of at least one of the two designated signers for recovery.

An image is also added to illustrate the process.

![image](https://github.com/smartvaults/smartvaults/assets/88842056/82d15056-8679-4ba0-8bfe-2095ffccb6c9)
@yukibtc yukibtc merged commit fdbbf18 into master Nov 3, 2023
@yukibtc yukibtc deleted the add-visual-examples branch November 3, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants