- bugfix {extends} with relative file path did not work #154

#158
smarty-php · Jan 27, 2016 · f59b00c · f59b00c
1 parent 04d9c5c
commit f59b00c
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/change_log.txt b/change_log.txt
@@ -4,8 +4,10 @@
   - bugfix {$smarty.section.customer.loop} did throw compiler error https://github.com/smarty-php/smarty/issues/161
     update of yesterdays fix
   - bugfix string resource could inject code at {block} or inline subtemplates through PHP comments https://github.com/smarty-php/smarty/issues/157		
-  - bugfix output filters did not observe nocache code flag https://github.com/smarty-php/smarty/issues/160
-
+  - bugfix output filters did not observe nocache code flhttps://github.com/smarty-php/smarty/issues/154g https://github.com/smarty-php/smarty/issues/160
+  - bugfix {extends} with relative file path did not work https://github.com/smarty-php/smarty/issues/154
+    https://github.com/smarty-php/smarty/issues/158
+
  26.01.2016
   - improvement observe Smarty::$_CHARSET in debugging console https://github.com/smarty-php/smarty/issues/169
   - bugfix compiling {section} did create warning

diff --git a/libs/Smarty.class.php b/libs/Smarty.class.php
@@ -121,7 +121,7 @@ class Smarty extends Smarty_Internal_TemplateBase
     /**
      * smarty version
      */
-    const SMARTY_VERSION = '3.1.30-dev/23';
+    const SMARTY_VERSION = '3.1.30-dev/24';
 
     /**
      * define variable scopes

diff --git a/libs/sysplugins/smarty_internal_compile_block.php b/libs/sysplugins/smarty_internal_compile_block.php
@@ -200,6 +200,7 @@ public function compile($args, Smarty_Internal_TemplateCompilerBase $compiler, $
         if ($compiler->template->compiled->has_nocache_code) {
             $output .= "\$_smarty_tpl->cached->hashes['{$compiler->template->compiled->nocache_hash}'] = true;\n";
         }
+        $output .= "\$_smarty_tpl->ext->_inheritance->blockNesting++;\n";
         if (isset($_assign)) {
             $output .= "ob_start();\n";
         }
@@ -213,6 +214,7 @@ public function compile($args, Smarty_Internal_TemplateCompilerBase $compiler, $
             $output .= "\$_smarty_tpl->tpl_vars[{$_assign}] = new Smarty_Variable(ob_get_clean());\n";
         }
         //$output .= "/*%%SmartyNocache:{$compiler->template->compiled->nocache_hash}%%*/\n";
+        $output .= "\$_smarty_tpl->ext->_inheritance->blockNesting--;\n";
         $output .= "}\n";
         $output .= "}\n";
         $output .= "/* {/block '{$_name}'} */\n\n";

diff --git a/libs/sysplugins/smarty_internal_resource_file.php b/libs/sysplugins/smarty_internal_resource_file.php
@@ -43,7 +43,12 @@ protected function buildFilepath(Smarty_Template_Source $source, Smarty_Internal
             ) {
                 throw new SmartyException("Template '{$file}' cannot be relative to template of resource type '{$_template->parent->source->type}'");
             }
-            $path = dirname($_template->parent->source->filepath) . DS . $file;
+            // if we are inside an {block} tag the path must be relative to current template
+            if (isset($_template->ext->_inheritance) && $_template->ext->_inheritance->blockNesting && $_template->parent->parent->_objType == 2) {
+                $path = dirname($_template->parent->parent->source->filepath) . DS . $file;
+            } else {
+                $path = dirname($_template->parent->source->filepath) . DS . $file;
+            }
             // normalize path
             $path = $source->smarty->_realpath($path);
             // files relative to a template only get one shot

diff --git a/libs/sysplugins/smarty_internal_runtime_inheritance.php b/libs/sysplugins/smarty_internal_runtime_inheritance.php
@@ -44,6 +44,13 @@ class Smarty_Internal_Runtime_Inheritance
      */
     public $tplIndex = - 1;
 
+    /**
+     * current block nesting level
+     *
+     * @var int
+     */
+    public $blockNesting = 0;
+
     /**
      * Array of source template names
      * - key template index