-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarty capture BC break since 3.1.28 #153
Comments
+1, |
+1, {capture assign="tpl_footer_text" name="tpl_footer_text"}
Footer Text
{/capture}
|
This still affects 3.1.29 for us. The capture is not useable in the main scope. @GodLesZ - you mentioned this is fixed in 3.1.29? Because I can recreate this bug in 3.1.29 |
@redemption, I meant an Error which was introduced in |
I just want to add that before this bug, it was possible to use capture content from a separate fetch. Eg in the @GodLesZ original post: index.tpl
test-plugin.tpl
index.php
Output of above would be the following: Content |
I was wondering, is this something that can be fixed and is intended to be fixed? Should we rewrite all uses of capture and stop using it? |
The fix is now in the master branch and will late be included in 3.1.30 Sorry that it took so long, I was longer time in hospital. |
Hey @uwetews we are very sorry to hear that you had health issues, we wish you a quick recovery! Take care of yourself! |
I get the same problem in the latest master-dev version. The capture is not visible outside the template it is defined. |
…en seen in other templates with {$smarty.capture.name} #153
Sorry, original error was introduced by mistake again. |
Since
3.1.28
Smartycapture
works different and breaks existing code, again.Also happend with
Smarty::getVariable()
, which was marked as deprecated and damaged at the same time (fixed since3.1.29
but anyways).Example for
capture
problemlayout.tpl
index.tpl
test-plugin.tpl
index.php
The captured content is not available in the index.tpl.
If I move the
capture
tags to the index.tpl, everything works fine. So it seems to have a local scope to the current template now but noscope
parameter like theassign
tag.Any chance to get
scope
parameter or some advice how to accomplish thecapture
usage across multiple templates?The text was updated successfully, but these errors were encountered: