Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be change private property accessMap, obsoleteProperties to protected #351

Closed
vuongminh-xx opened this issue Apr 14, 2017 · 1 comment
Closed

Should be change private property accessMap, obsoleteProperties to protected #351

vuongminh-xx opened this issue Apr 14, 2017 · 1 comment

Comments

@vuongminh-xx
Copy link

vuongminh-xx commented Apr 14, 2017 •
edited
Loading

When a custom class extends Smarty. Sometime we need it for make some magic property or resolved old property of custom library.
vuongminh-xx pushed a commit to vuongminh-xx/smarty that referenced this issue Apr 14, 2017
@vuongxuongminh
Update Smarty.class.php
dadaf0b 
Change **private** property `accessMap`, `obsoleteProperties` to **protected**. Refer issue smarty-php#351
@vuongminh-xx vuongminh-xx mentioned this issue Apr 14, 2017
Closed
@vuongminh-xx
Copy link
Author

Or we should be add some method to support add property name to access map

uwetews added a commit that referenced this issue May 19, 2017
@uwetews
- change properties $accessMap and $obsoleteProperties from private t…
f0e215b 
…o protected

    #351
@uwetews uwetews closed this as completed May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uwetews @vuongminh-xx