Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new forced unclosed block compiler exception #397

Closed
ophian opened this issue Oct 16, 2017 · 2 comments
Closed

new forced unclosed block compiler exception #397

ophian opened this issue Oct 16, 2017 · 2 comments

Comments

@ophian
Copy link

ophian commented Oct 16, 2017

in latest dev 3.1.32-25 version brought in some issues with elder working code.

Hi Uwe

I don't say its an issue or bug, and do only want to make this noticable for your further work,

We had to 2 occurences of exceptions using code like

{$link="{if $file.hotlink}{$file.path}{else}{$file.full_file}{/if}"}

throwing an unclosed "{else}" in doubled quoted string <-- and now easy to solve by using brackets

and a special one in a modifier

{$smarty.const.UNMET_REQUIREMENTS|sprintf:"{if $requirements_failures.{$plug.class_name}.s9y}s9y $plug.requirements.serendipity,{/if} {if $requirements_failures.{$plug.class_name}.php}PHP $plug.requirements.php,{/if} {if $requirements_failures.{$plug.class_name}.smarty}Smarty $plug.requirements.smarty{/if}"}

throwing unclosed "{if}" in doubled quoted string <-- which also is avoidable using brackets,

{$smarty.const.UNMET_REQUIREMENTS|sprintf:"({if ($requirements_failures.{$plug.class_name}.s9y)}s9y {$plug.requirements.serendipity},{/if}{if ($requirements_failures.{$plug.class_name}.php)} PHP {$plug.requirements.php},{/if}{if ($requirements_failures.{$plug.class_name}.smarty)} Smarty {$plug.requirements.smarty}{/if})"}

but outputs the brackets. (That is ok for me this special case, but might be an unwanted behaviour in other cases.)

Feel free to close,

@ophian ophian changed the title new forced unclosed block compiler exception in latest dev 3.1.32-25 version new forced unclosed block compiler exception Oct 16, 2017
@uwetews
Copy link
Contributor

uwetews commented Oct 18, 2017

This is fixed now.

@uwetews uwetews closed this as completed Oct 18, 2017
@ophian
Copy link
Author

ophian commented Oct 18, 2017

👍 works, thanks!

wisskid pushed a commit that referenced this issue Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants