Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1.32] Smarty::compileAllTemplates ignores $extension parameter #437

Closed
caugner opened this issue May 2, 2018 · 4 comments
Closed

[3.1.32] Smarty::compileAllTemplates ignores $extension parameter #437

caugner opened this issue May 2, 2018 · 4 comments

Comments

@caugner
Copy link
Contributor

caugner commented May 2, 2018

We run the following in a CI job:

<?php
$smarty = new Smarty();
$smarty->setCompileDir(...);
$smarty->setTemplateDir(...);


$smarty->compileAllTemplates('.tpl', true);

This has always worked fine.

However, after upgrading from 3.1.31 to 3.1.32, compileAllTemplates reports several errors in files without the .tpl extension.

@caugner
Copy link
Contributor Author

caugner commented May 2, 2018

See reason here: 3fc8abe#r28821028

See my PR for a solution here: #438

@caugner
Copy link
Contributor Author

caugner commented May 14, 2018

cc @uwetews

@uwetews
Copy link
Contributor

uwetews commented May 17, 2018

The fix is now in the master branch

@uwetews uwetews closed this as completed May 17, 2018
@JayBizzle
Copy link

@uwetews What is the release schedule for these type of bugs? Seems like pushing a new release now would be beneficial.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants