outputfilter.trimwhitespace.php strips KnockoutJS comments

[vanderlee]

KnockoutJS has a syntax for MVVM that uses HTML comments in the form of <!-- ko ... -->...</!-- /ko -->.

The outputfilter.trimwhitespace.php output filter strips out all comments (except the MSIE-specific ones). As far as I know, there is no workaround or fix except stripping out the line that removes the comments from the Smarty code; obviously not a good solution.

Is it possible to add a way to keep these (or other framework's) comments?

See this old stackoverflow for more details: http://stackoverflow.com/questions/15009881/smarty-comment-stripping-and-knockoutjs

[mohrt]

outputfilter.trimwhitespace.php is not loaded by default, you must explicitly load it. Just don't load the filter if you don't want it applied?

[vanderlee]

You are correct, but then it's still an all-or-nothing deal.
Either you get no trimming at all or you get whitespace trimming AND comment trimming.

It would be nice if they were either separated (which I guess would be a performance drain) or configurable.

[mohrt]

You can make them separate yourself with custom output filters. Copy the filter and make your own rules. Another approach, make a prefilter to replace the comment tags you want to keep with a placeholder, then swap them back with an output filter after the trimming is complete (load your filter after the trimwhitespace filter.)

[uwetews]

The change is committed now