Fix foreachelse #531
Closed
Fix foreachelse #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to address issue #506. After this patch the foreach logic always count the total number of elements when the underlying structure can easily be queried. E.g.: arrays and Countables can be queried with count() for the total number of elements. For all iterators we do not know the total element count in advance and calculating it is a wasteful operation. And it can be dangerous, too: forward-iterators cannot be rewinded and the foreach-loop will break. So with this patch the @ToTal property will be simply set to -1 for iterators. This has implications to other properties as well, when foreach is used with iterarors: The @show property is always true (even when there are no elements), and @last is always false. This patch changes a runtime function call. So all templates that uses foreach must be recompiled.
|
this doesn't fix the issue in the current master. working on another implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fix try to address issue #506. See commit message in cda5bb9