Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set $errcontext argument optional to support PHP 8 #604

Closed
wants to merge 1 commit into from
Closed

Set $errcontext argument optional to support PHP 8 #604

wants to merge 1 commit into from

Conversation

xorti
Copy link
Contributor

@xorti xorti commented Jul 29, 2020

  • Argument is optional and deprecated in PHP 7.2

@wisskid
Copy link
Contributor

wisskid commented Sep 4, 2020

Why not remove it all together?

@wisskid wisskid mentioned this pull request Sep 4, 2020
Closed
@xorti
Set $errcontext argument optional to support PHP 8
e128953 
- Argument is optional and deprecated in PHP 7.2
@xorti xorti force-pushed the fix-error-handler-function branch from 9e44616 to e128953 Compare September 6, 2020 21:37
@xorti
Copy link
Contributor Author

xorti commented Sep 6, 2020

@wisskid I don't want to break the compatibility with earlier versions of PHP, smarty's latest version still supports >=5.2.

Removing it, might not break the house, but making it optional sounds safer.

@wisskid
Copy link
Contributor

wisskid commented Sep 11, 2020

Thank you, I've included this in #608 fixing several other php8-issues in one go.

@wisskid wisskid closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glensc glensc glensc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xorti @wisskid @glensc