Bubbling up of parent scope in template blocks with inheritance chain #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryo
commented
Jan 23, 2023
| $_stack = array(); | ||
| $ptr = $tpl->parent; | ||
| if ($mergedScope && isset($ptr) && $ptr->_isTplObj()) { | ||
| $_stack[] = $ptr; | ||
| if ($tpl->inheritance && $tagScope & Smarty::SCOPE_PARENT) { |
There was a problem hiding this comment.
Templates with an inheritance chain have an implicit Smarty::SCOPE_PARENT. Variables should not bubble up outside the inheritance chain implicitly so I have to explicitly test against the tag scope (not the merged one).
maryo
force-pushed
the
inheritance-parent-scope
branch
4 times, most recently
from
0940874
to
3b9e536
Compare
maryo
force-pushed
the
inheritance-parent-scope
branch
from
3b9e536
to
efd40aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating variable in parent scope (when the
scope=parentis explicitly used on a tag likeassign) now bubbles up (to the including template) even when the included template is part of an inheritance chain as it did prev3.1.28.Fixes #850