[WIP] Add new action, click each element in list and drag & drop #47
Conversation
|
Nice, I was going to have to write a drag and drop step, thank you! :) |
packages/browser.smash
Outdated
| @@ -148,6 +148,20 @@ | |||
| } | |||
| } | |||
|
|
|||
| * Click each {{element}} { | |||
| if(!Array.isArray(element)){ | |||
| const elems = await $(element); | |||
There was a problem hiding this comment.
I think you meant to use $$(), which returns multiple elements.
There was a problem hiding this comment.
Also, I don't really envision many users passing in an array, as everything in smashtest is a string
There was a problem hiding this comment.
i set a array if people need to set array with multiple element haven't a same Id or class
There was a problem hiding this comment.
But it won't be easy for them to set an array. They'd have to set it in a code block using something like g().
Click each [one, two] // NOT an array - this is the string 'one, two'
Easier just to use multiple Click steps in succession.
There was a problem hiding this comment.
Oh ! nice I did not think about doing it like that but it's a great idea a table disguised to make several clicks on items of different name
packages/browser.smash
Outdated
| } | ||
| } | ||
|
|
||
| * Drag {{dragPosition}} in {{dropPosition}} { |
There was a problem hiding this comment.
I would reword this as
Drag {{elementFrom}} to {{elementTo}} and Drag {{elementFrom}} to {{x}}, {{y}} (2 different functions)
See dragAndDrop() docs: https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/lib/input_exports_Actions.html
There was a problem hiding this comment.
Ok i can reword this and create 2 different functions.
|
Not a final function i work on it, i push so that you can see where I am |
packages/browser.smash
Outdated
| } | ||
|
|
||
| * Drag {{elementFrom}} to {{x}}, {{y}} { | ||
| await browser.driver.actions({bridge: true}).dragAndDrop(dragPosition, {x: parseInt(x), y: parseInt(y)}).perform(); |
There was a problem hiding this comment.
Variable dragPosition doesn't exist. A unit test would catch that :)
There was a problem hiding this comment.
Sorry iu didn't test this :)
packages/browser.smash
Outdated
| elems.forEach(elem => elem.click()); | ||
| } | ||
|
|
||
| * Drag {{elementFrom}} in {{elementTo}} { |
packages/browser.smash
Outdated
| @@ -148,6 +148,20 @@ | |||
| } | |||
| } | |||
|
|
|||
| * Click each {{element}} { | |||
| const list = element.split(","); | |||
| const elems = await $$(list); | |||
There was a problem hiding this comment.
No this isn't right. You had it right before. You shouldn't take a comma-separated list (among many things, the comma is a special character in an EF and this will interfere with that). You just $$(element) and do the forEach() below.
|
yeah i write this test |
I add a new function for multi click on page :
I add a drag and drop function.