Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to internal pages (like chrome://apps) #1

Open
weakish opened this issue May 14, 2015 · 7 comments · May be fixed by #2
Open

Redirect to internal pages (like chrome://apps) #1

weakish opened this issue May 14, 2015 · 7 comments · May be fixed by #2

Comments

@weakish
Copy link

weakish commented May 14, 2015

Failed to redirect new tab to apps page (chrome://apps/).

Maybe change document.location.href to chrome.tabs.update until #11854 of chromium is resolved?

@weakish
Copy link
Author

weakish commented May 14, 2015

Hmm, using chrome.tabs.update will cause recovering from crashed chrome hard: chromium/#67755

@smblott-github
Copy link
Owner

Thanks, @weakish. I'm going to guess that chrome "bug" applies to the existing implementation too.

I'll look a chrome.tabs.

@weakish
Copy link
Author

weakish commented May 14, 2015

@smblott-github chromium/#67755 does not affect document.location.href.

smblott-github pushed a commit that referenced this issue May 14, 2015
Fixes #1. Kinda.  See discussion there.
@smblott-github
Copy link
Owner

So, b2d9204 fixes your original issue.

@smblott-github smblott-github linked a pull request May 14, 2015 that will close this issue
@m7ess5
Copy link

m7ess5 commented Jun 5, 2018

hi, the plugin seems not to work opening a new tab for this URL: chrome-extension://nlipoenfbbikpbjkfpfillcgkobtgpmj/upload.html (addon page from https://www.awesomescreenshot.com/)

@smblott-github
Copy link
Owner

@maustyle I took a look at the code (it's only about 15 lines). There's nothing in there to prevent the redirection per se. I suspect it's a Chrome "security feature". (So, probably nothing I can do.)

@tgr
Copy link

tgr commented Apr 15, 2019

chrome://bookmarks/... URLs don't work either, sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants