Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied black to python files and clang-format to c++ #128

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

gjkennedy
Copy link
Collaborator

Added hooks to enforce black formatting for python and clang-format with style=Google for c++. This is designed to enforce style consistency from all contributors.

@gjkennedy gjkennedy requested a review from timryanb September 9, 2022 14:31
@A-CGray
Copy link
Contributor

A-CGray commented Sep 9, 2022

Just a note in case you didn't already know, once you guys merge this, you can add the squashed commit hash to a .git-blame-ignore-revs file (like this) so that it's ignored from the git blame for the repo, doesn't work on GitHub yet but it does locally. We typically do this after applying big formatting changes, otherwise, the git blame becomes pretty useless

@timryanb timryanb merged commit 2e02aa8 into smdogroup:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants