-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue in AssembleMatType procedure #169
Conversation
tacs/problems/modal.py
Outdated
# Make previous auxiliary loads are removed | ||
self.assembler.setAuxElements(None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other TACS problems (StaticProblem/TranientProblem) may have set an AuxElem loads in a previous call. This line makes sure that AuxElems is empty at the begining of each ModalProblem analysis, since we have no use for them here. Setting this to None in Python is equivalent to setting it to NULL in c++
$testflo -b .
)assembleMatType
procedure which was causing TACSFrequencyAnalysis to behave differentlygetMatType
isn't an additive procedure (likeaddJacobian
) so everytime the auxiliary element contribution is computed, it overwrites the element contribution