Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pymeshloader bug involving unsorted BDF files #192

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Fixing pymeshloader bug involving unsorted BDF files #192

merged 6 commits into from
Mar 14, 2023

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Mar 13, 2023 •
edited
Loading

  • Some of the logic in pyMeshLoader makes assumptions that the id numbering in the BDF file is always ascending
  • If this isn't the case (in particular for node IDs), this can cause pyMeshLoader to crash or behave unpredictably
  • This can be fixed by making sure the ID ordering read in from the BDF file is preserved in certain places in pyMeshLoader
  • Retroactively modified two of the integration tests bdf files to non-ascending node ordering to verify solution and catch issue in future

@timryanb timryanb requested review from A-CGray and gjkennedy March 13, 2023 21:58
@timryanb timryanb marked this pull request as draft March 13, 2023 23:20
@timryanb timryanb marked this pull request as ready for review March 14, 2023 13:15
@gjkennedy gjkennedy merged commit 0c26129 into smdogroup:master Mar 14, 2023
@timryanb timryanb deleted the dummy-node-fix branch March 14, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjkennedy gjkennedy gjkennedy approved these changes

@A-CGray A-CGray Awaiting requested review from A-CGray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @gjkennedy