-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nonlinear shell elements and solver #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary implementation until I can figure out how to figure it out automatically from the element/contitutive objects.
This reverts commit 03676ce.
This reverts commit 92a9f5d.
timryanb
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables some geometrically nonlinear shell elements in TACS, and adds a set of nonlinear solvers to pyTACS which can be used in staticProblems but are extensible to use in other problems too.
Opening this as a draft to get your opinions on the current implementation
Summary of changes
TACSQuadraticRotation
leading to inconsistency between residuals computed byassembleRes
andassembleJacobian
_factorOnNext
attribute into_preconditionerUpdateRequired
and_jacobianUpdateRequired
getForces
method which separates the internal and external components of the residualisNonlinear
flag is set in the pyTACS object, and this flag is passed on to any problems created from the object.applyBCs
inStaticProblem
withsetBCs
so thatStaticProblem
works with non-zero Dirichlet boundary conditionsToDo before merging: