Time spectral finite-element implementation #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komahanb
reviewed
Apr 6, 2023
| @@ -56,6 +56,9 @@ class BCSRMat : public TACSObject { | |||
| // Free the matrix | |||
| ~BCSRMat(); | |||
|
|
|||
| // Create a duplicate of the matrix without copying values | |||
| BCSRMat *createDuplicate(); | |||
|
|
|||
There was a problem hiding this comment.
@gjkennedy using Fortran terminology: a mold() function would allocate but doesn't copy values
There was a problem hiding this comment.
I think duplicate is a nice description for this. This function will be used infrequently and typically not in instances when you actually want to copy the values of the matrix.
timryanb
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code implements a time-spectral approach for integrating the equations of motion in time. This is only for first-order systems in time (such as thermal problems) and could be extended to second-order systems or periodic systems.