-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Tsai-Wu to work with safety factors #203
Conversation
Tests are failing because these changes affect some of the reference values that are tested against, I can update them if the two of you are happy with these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. Let's update the reference values so the composite tests pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give @gjkennedy a chance to review before merging
I do have some concerns with this approach.
|
@gjkennedy I added back the original Tsai-Wu index as an option but made the strength ratio version the default, is this good with you? |
The issues that I thought were in these Tsai-Wu sensititivities actually turned out to be in the Von Mises criterion sensitivities (see #212 ) so this PR is good to be merged. |
Currently, the Tsai-Wu failure evaluation directly returns the value of the quadratic Tsai-Wu criterion:
This has the disadvantage that the failure value does not scale linearly with the stresses and thus the typical approach of applying a safety factor to a failure constraint during optimisation is not valid. In other words, constraining the structure to have a maximum failure value of 1/2 does not mean the structure has a factor of safety of 2.
The von-Mises is also a quadratic failure criteria, but we get around the issue above by using a square root:
For Tsai-Wu, we can't simply take a square root because the failure criteria contains quadratic and linear terms and can sometimes be negative. Instead we have to find the factor by which we would need to scale up/down the stresses to be at the failure boundary:
This equation has the roots
Since the Tsai-Wu criterion is only physical if the F matrix is positive definite, the only positive root is
This PR modifies the Tsai-Wu failure criterion calculation in the Orthotropic ply class so that the value returned is the$\alpha$ value from the above equation. Which means that the criterion can safely be used with safety factors and that the OrthotropicPly class returns the von-Mises failure criteria when used with an isotropic material.
I also implemented the necessary derivatives and verified them against FD using
testFailureSens
:This idea is based on https://doc.comsol.com/6.0/doc/com.comsol.help.sme/sme_ug_theory.06.43.html