Conda numba build fix #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timryanb
commented
Aug 3, 2023
timryanb
commented
- anaconda sometimes pulls old versions of numba which break the install
- Adding version pin for numba to conda recipe
A-CGray
reviewed
Aug 3, 2023
| @@ -75,7 +75,7 @@ requirements: | |||
| - metis ==5.1.0 | |||
| - mpi4py | |||
| - pynastran | |||
| - numba | |||
| - numba >=0.55.2 | |||
There was a problem hiding this comment.
Should we add the same minimum version to the setup.py requirements?
There was a problem hiding this comment.
I dont think we need to, but we can. This appeared to be an issue specifically with the conda packages dependencies for older versions of numba that didn't have a version upperbound for newer numpy versions. This could lead to a situation where an old version of numba could be installed with a new (incompatible) version of numpy.
There was a problem hiding this comment.
ok, if it's a very conda-specific issue then I guess we can go with this as is
A-CGray
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.