Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of complex values in blade stiffened shell testing functions #253

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

A-CGray
Copy link
Contributor

@A-CGray A-CGray commented Sep 22, 2023

@bburke38 was running into compilation errors with the latest version of clang due to some print statements involving TacsScalars that weren't written correctly to handle the complex case. This PR should fix those issues.

@A-CGray
Copy link
Contributor Author

A-CGray commented Sep 22, 2023

@bburke38 please confirm that this compiles correctly for you in complex mode before we merge

@bburke38
Copy link
Contributor

I'm still running into issues in TACSBladeStiffenedShellConstitutive.cpp around line 2736. I'll see if I can suggest some edits.

Copy link
Contributor

@bburke38 bburke38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to compile with the current version of this PR. I am in the process of making a few more changes which I will merge into this PR.

Copy link
Contributor

@bburke38 bburke38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can now compile in complex with the new changes.

@timryanb timryanb merged commit f30698c into master Sep 25, 2023
5 checks passed
@timryanb timryanb deleted the complexPrintFix branch September 25, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants