TacsBuilder init refactor #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring MPhys TacsBuilder classes init arguments to be more consistent.
Right now we have a number of inputs that have to be passed in through an options dictionary and some that do not.
The
mesh_file, for example, is passed in through the options dict, even though it is not optional.I've broken each of the inputs out and given each their own argument in the init function make things more consistent.
Since this is a breaking change, I still allow for the old method (passing the inputs through an options dict) to work, with a DeprecationWarning raised in this case. I've tentatively set the full deprecation of this feature to take place in version 3.7.0 to give people time to update.