-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with nonlinear problems when using MPhys wrapper #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edShellConstitutive`
@timryanb , took me a while but I finally got this sorted! |
timryanb
reviewed
Jun 24, 2024
tacs/problems/static.py
Outdated
"resetBeforeSolve": [ | ||
bool, | ||
False, | ||
"Reset the states before every solve, this can be useful for avoiding issues when testing derivatives with dinite-difference/complex-step", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo in "finite"
timryanb
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, this looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this by passing the new stiffness matrix and preconditioner to the nonlinear solvers' linear solvers.
I also added a version of the nonlinear hemispherical shell integration test that uses the MPhys wrapper so that using the nonlinear solver through MPhys is covered in the tests. As part of this I found that getting accurate complex-step derivatives was very sensitive to how the solver converged. I therefore added an option to the static problem class that tells TACS to reset the state variables before every solve, which seemed to fix the issue.
Finally I altered the mphys buckling integration test to stop it writing out loads of .f5 files