Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifying BladeStiffenedShellConstitutive class to require fewer inputs #286

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Modifying BladeStiffenedShellConstitutive class to require fewer inputs #286

merged 6 commits into from
Mar 11, 2024

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Dec 11, 2023 •
edited
Loading

  • Adding default inputs to BladeStiffenedShellConstitutive to make initializing easier
  • Holding off merging this in until v3.7.0 update

@timryanb timryanb requested a review from A-CGray December 11, 2023 16:07
A-CGray
A-CGray approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@A-CGray A-CGray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we require a version bump after this as it's technically a backwards incompatible change right?

@timryanb timryanb marked this pull request as draft December 15, 2023 16:26
@timryanb timryanb marked this pull request as ready for review March 11, 2024 15:16
@timryanb timryanb merged commit 9818a92 into smdogroup:master Mar 11, 2024
5 checks passed
@timryanb timryanb deleted the blade-con-mod branch March 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-CGray A-CGray A-CGray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @A-CGray