Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to tag node ids in MPhys TacsBuilder #287

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Adding ability to tag node ids in MPhys TacsBuilder #287

merged 7 commits into from
Feb 9, 2024

Conversation

timryanb
Copy link
Collaborator

No description provided.

@A-CGray
Copy link
Contributor

A-CGray commented Feb 1, 2024

Ran into an issue when trying to use this new capabilities with node IDs I'd gotten from getGlobalNodeIDsForComps, those returned node IDs are not python ints but instead np.int64, so I extended the isinstance check you implemented here to catch both python and numpy integer types

@A-CGray A-CGray marked this pull request as ready for review February 9, 2024 19:34
@timryanb timryanb requested a review from A-CGray February 9, 2024 20:33
@timryanb
Copy link
Collaborator Author

timryanb commented Feb 9, 2024

Looks good to me, nice job @A-CGray

@A-CGray A-CGray merged commit 5948e1a into smdogroup:master Feb 9, 2024
5 checks passed
@timryanb timryanb deleted the tagged_node_ids branch February 9, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-CGray A-CGray A-CGray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @A-CGray