Adding random generator seed to all pytacs/mphys tests #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran the CI 10 times in a row without any tests failing. The issue seems to be resolved for now |
A-CGray
reviewed
Mar 14, 2024
| @@ -63,6 +64,9 @@ def setUp(self): | |||
| # Populate fd/cs perturbation vectors based on user-defined method | |||
| self.setup_tacs_vecs(self.fea_assembler, self.dv_pert, self.xpts_pert) | |||
|
|
|||
| # Seed random number generator in tacs for consistent test results | |||
| elements.SeedRandomGenerator(0) | |||
There was a problem hiding this comment.
How does seeding the random generator in elements affect the random generator used by the Eigensolver? Are they the same?
There was a problem hiding this comment.
It calls the same C++ seed function srand that should seed all random number functions used in tacs.
A-CGray
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #301. Should fix intermitent test failures we've been seeing on CI recently