Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_trans_beam FD step size #317

Merged
merged 1 commit into from
May 28, 2024
Merged

Update test_trans_beam FD step size #317

merged 1 commit into from
May 28, 2024

Conversation

A-CGray
Copy link
Contributor

@A-CGray A-CGray commented May 24, 2024

Similar to #316 , we are seeing some hard to reproduce test failures in the xpt sens test in test_trans_beam. I can't be 100% sure that this step size change fixes the error but it does reduce the largest relative error by roughly 2 orders of magnitude:

Before:

Testing sinusoid_compliance xpt sens:
analytic: 12.398071807030135
      FD: 12.397875767788946
    diff: 0.00019603924118882787
rel diff: 1.581207499360238e-05

After:

Testing sinusoid_compliance xpt sens:
analytic: 12.398070774567254
      FD: 12.398069415553437
    diff: 1.3590138170371802e-06
rel diff: 1.0961494265906186e-07

@A-CGray A-CGray requested a review from timryanb May 24, 2024 21:01
@timryanb timryanb merged commit 3adc918 into master May 28, 2024
5 checks passed
@timryanb timryanb deleted the A-CGray-patch-1 branch May 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants