Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

allow custom fields in the custom report method #29

Merged
merged 5 commits into from
Feb 12, 2019

Conversation

tangerilli
Copy link
Contributor

See the note about custom fields at the end of the field list for details

See the note about custom fields at the end of [the field list](http://www.bamboohr.com/api/documentation/employees.php#listFields) for details
@internetlee
Copy link

@tangerilli - thank you for looking into this. i flagged this #29, too, and came back to see if i could tackle a solution. this looks great! i think there may be another piece or two to consider here.

if not f.startswith('custom') and not self.employee_fields.get(f):

only non-tabular fields are assigned prefix 'custom'. custom tables are assigned a four character int formatted as a string [a custom table we have is 430{x} where x+=1 , or a float formatted as a string - searching for this example again. cannot recall which field we have for this - when i find it i'll show the example.

thanks again!

@smeggingsmegger smeggingsmegger merged commit cea55ad into smeggingsmegger:master Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants