Skip to content

Commit

Permalink
Merge pull request #1062 from smeup/master-editable-field-fix
Browse files Browse the repository at this point in the history
Bugfix: editable text field in cell update was testing/updating initialValue instead of value.
  • Loading branch information
stefanomacconi authored Jun 30, 2021
2 parents d4b1154 + 612ae24 commit 36525b6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions packages/ketchup-showcase/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@mdi/font": "^2.8.94",
"@vaadin/vaadin-upload": "^4.2.2",
"element-ui": "^2.4.8",
"ketchup": "^1.0.12",
"ketchup": "^1.0.12.1",
"style-loader": "^0.23.1",
"stylus": "^0.54.5",
"stylus-loader": "^3.0.2",
Expand Down Expand Up @@ -70,4 +70,4 @@
"vaadin": {
"disableUsageStatistics": true
}
}
}
4 changes: 2 additions & 2 deletions packages/ketchup/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ketchup",
"version": "1.0.12",
"version": "1.0.12.1",
"keywords": [
"Sme.UP",
"KetchUP",
Expand Down Expand Up @@ -82,4 +82,4 @@
"type": "git",
"url": "https://github.com/smeup/ketchup.git"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2741,12 +2741,14 @@ export class KupDataTable {
cell.data['checked'] = value === 'on' ? false : true;
}
} else {
cell.obj.k = value;
if (cell.obj) {
cell.obj.k = value;
}
cell.value = value;
cell.displayedValue = null;
cell.displayedValue = getCellValueForDisplay(column, cell);
if (cell.data && cell.data['initialValue'] !== undefined) {
cell.data['initialValue'] = value;
if (cell.data && cell.data['value'] !== undefined) {
cell.data['value'] = value;
}
}
this.refresh();
Expand Down

0 comments on commit 36525b6

Please sign in to comment.