Skip to content

Commit

Permalink
Merge pull request #2125 from apuliasoft/fix/kup-automplete-combobox
Browse files Browse the repository at this point in the history
  • Loading branch information
lucafoscili authored Oct 18, 2024
2 parents c521a9f + 3277450 commit ce526ff
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,8 @@ export class KupAutocomplete {
this.#closeList();
return false;
}
const hasError = this.error.trim().length > 0;
const hasAlert = this.alert.trim().length > 0;
const hasError = this.error?.trim().length > 0;
const hasAlert = this.alert?.trim().length > 0;
const topOffset = hasError || hasAlert ? -20 : 0;
this.#textfieldWrapper.classList.add('toggled');
this.#listEl.menuVisible = true;
Expand Down
4 changes: 2 additions & 2 deletions packages/ketchup/src/components/kup-combobox/kup-combobox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -422,8 +422,8 @@ export class KupCombobox {
return;
}
// Manage list open while helperline is displayed
const hasError = this.error.trim().length > 0;
const hasAlert = this.alert.trim().length > 0;
const hasError = this.error?.trim().length > 0;
const hasAlert = this.alert?.trim().length > 0;
const topOffset = hasError || hasAlert ? -20 : 0;
this.#textfieldWrapper.classList.add('toggled');
this.#listEl.menuVisible = true;
Expand Down

0 comments on commit ce526ff

Please sign in to comment.