Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): aws s3 region, webup-continuum trigger #1802

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(ci): aws s3 region, webup-continuum trigger #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b2248
fix(ci): use correct aws region for both pipelines
paolofacchinetti Mar 12, 2024
c28c080
fix(ci): webup dispatch trigger has mandatory event type
paolofacchinetti Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/continuum.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:

env:
VERSION: 10.0.0-SNAPSHOT
AWS_REGION: eu-south-1

jobs:
ketchup-release:
Expand Down Expand Up @@ -41,7 +42,7 @@ jobs:
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-east-1
aws-region: ${{ env.AWS_REGION }}

- name: Upload artifacts to AWS S3
run: |
Expand Down Expand Up @@ -84,6 +85,7 @@ jobs:
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${{ secrets.ROBBY_SMEUP_PAT }}" \
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/smeup/webup-project/dispatches
https://api.github.com/repos/smeup/webup-project/dispatches \
-d '{"event_type": "ketchup-continuum-rebuild"}'

# TODO: add webup.js triggers
14 changes: 10 additions & 4 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
tags: "*"

env:
AWS_REGION: eu-south-1

jobs:
ketchup-release:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -32,11 +35,14 @@ jobs:
zip -qr ketchup-components.zip packages/ketchup/dist/ketchup
ls -alh ketchup-components.zip

- name: Setup AWS
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: ${{ env.AWS_REGION }}

- name: Upload artifacts to AWS S3
run: |
aws s3 cp ketchup.zip s3://smeup-ketchup/npm-pub/ketchup-stencil/${{ github.ref_name }}/zip/ketchup.zip
aws s3 cp ketchup-components.zip s3://smeup-ketchup/npm-pub/ketchup-stencil/${{ github.ref_name }}/zip/ketchup-components.zip
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_DEFAULT_REGION: eu-south-1