New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/image list/responsive columns prop #2067

Merged

lucafoscili merged 2 commits into develop from feat/image-list/responsiveColumnsProp

Sep 20, 2024

Collaborator

zammarchi-smeup commented Sep 19, 2024

THIS PR NEEDS TO BE ACCEPTED WITH ITS WEBUP.JSF COUNTERPART:
(https://github.com/smeup/webup-project/compare/develop...Add_IMLResponsiveColumns?expand=1)

Prop Column for kup-image-list is now a KupDataNode and has 3 possibilities for its value:

"N" : acts as the previous one
"N;N" : first number is used for phone and tablet, second one for pc
"N;N;N" : first number for phone, second for tablet, third for pc

Leonardo-Signorelli added 2 commits

September 12, 2024 18:21


          feat / manage responsive column

8779e3f


          fix / fix value from columns

d3b2c5a

zammarchi-smeup requested review from lucafoscili and pasere-smeup as code owners

September 19, 2024 15:27

lucafoscili approved these changes

View reviewed changes

lucafoscili merged commit 107c3df into develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet