Turn into optional extension json-stream can depend on #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smheidrich
changed the title
smheidrich
changed the title
smheidrich
force-pushed
the
switch-to-setuptools-rust
branch
12 times, most recently
from
6dce81e
to
e97d179
Compare
smheidrich
force-pushed
the
switch-to-setuptools-rust
branch
from
e97d179
to
1310a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to turn the Rust tokenizer into an optional extension, meaning that building it from the sdist is allowed to fail. The purpose of this is to allow json-stream to have this package as a dependency but be able to fall back to the pure Python tokenizer if no wheels are available and the sdist build fails.
Maturin doesn't support optional extensions and the recommendation from their side is to use setuptools-rust instead (PyO3/maturin#1081), so that's what we do here as well.
Also gets rid of the dependency on json-stream.