Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files from lib to src and index into src #85

Merged
merged 5 commits into from
May 4, 2024

Conversation

erikyo
Copy link
Collaborator

@erikyo erikyo commented May 2, 2024

This commit relocates files from the lib directory to the src directory and places index inside src.

  • Updated paths (scripts and test)
  • Added typescript dependency and the required stuff to build the library

This adjustment enables publishing everything with the build process and ensures all files, including types, are contained within the same folder. Consequently, there won't be a need to publish a .d.ts file in the root directory.

While the build step becomes necessary, it guarantees that types will always remain synchronized with those from @definitely-typed. Nonetheless, someone must execute the build step.

@erikyo erikyo mentioned this pull request May 2, 2024
10 tasks
@erikyo erikyo changed the base branch from master to development May 4, 2024 22:02
erikyo added 3 commits May 5, 2024 00:06
- updated paths
- as suggested by @johnhooks to set as source for tests the "src" folder (and not the builded one)
- updated node internal modules paths prefix (ref. https://nodejs.org/api/module.html#modules-nodemodule-api)
@johnhooks
Copy link

johnhooks commented May 4, 2024

@smhg I don't know what level of permission is required, though I am willing to do code review for @erikyo if we can get that setup.

Update: it actually looks like I can submit a review as is.

@erikyo erikyo self-assigned this May 4, 2024
@erikyo erikyo merged commit 052d3d2 into smhg:development May 4, 2024
4 checks passed
@erikyo erikyo deleted the move-to-src branch May 4, 2024 22:53
@erikyo erikyo mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants