Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting boolean when inserting into int #202

Closed
MakarMS opened this issue Jan 10, 2024 · 0 comments
Closed

Converting boolean when inserting into int #202

MakarMS opened this issue Jan 10, 2024 · 0 comments

Comments

@MakarMS
Copy link

MakarMS commented Jan 10, 2024

When inserting, a problem was found that if you pass a boolean as a value, this value is converted to int and clickhouse cannot handle this case because boolean is expected as input data, not int.

This is due to implode in StrictQuoteLine.php in the quoteRow method, which convert boolean to int.

     * @param $row
     * @param bool $skipEncode
     * @return string
     */
    public function quoteRow($row,bool $skipEncode=false )
    {
        return implode($this->settings['Delimiter'], $this->quoteValue($row,$skipEncode));
    }
MakarMS pushed a commit to MakarMS/phpClickHouse that referenced this issue Jan 10, 2024
isublimity added a commit that referenced this issue Jan 16, 2024
fix(#202): Fix converting boolean when inserting into int and fix(#194): Fix unexpected readonly mode with specific string in query
@MakarMS MakarMS closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant