Refactor LastUsedValuesStore to use sequences instead of LinkedList #3

smichel17 · 2021-10-18T11:37:18Z

To be sent upstream once streetcomplete#3373 is merged

The undo button popup menu allegedly exists because the history screen makes it slower to undo the most recent entry. However, the menu itself *also* makes it slower to undo the most recent entry, so it barely saves any time. So, we might as well just open the full history directly. streetcomplete#3330 (comment)

Undoing the most recent entry in the history is probably the most common action, so we'd like it to be faster. This removes a tap by pre-selecting the first entry when the sidebar is first opened.

This makes the most recent edit start at the bottom, so when you tap the undo button, you don't need to move your hand far to undo the most recent edit. It would be nice to have a slightly larger bottom padding, so the button lines up perfectly and it's just a double-tap.

fixes streetcomplete#2437

'Concrete lanes' not 'Concrete without full cover'

…ht mode fade out colors

# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/data/quest/QuestAutoSyncer.kt

smichel17 · 2021-10-19T14:25:22Z

Why is favs @Injected here, and then also manually initialized?

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/AGroupedImageListQuestAnswerFragment.kt

Lines 38 to 46 in 6da0377

    
           @Inject internal lateinit var favs: LastPickedValuesStore<I> 
        
           private val selectedItem get() = imageSelector.selectedItem 
        
           protected open val itemsPerRow = 3 
        
           override fun onAttach(ctx: Context) { 
        
               super.onAttach(ctx) 
        
               favs = LastPickedValuesStore(PreferenceManager.getDefaultSharedPreferences(ctx.applicationContext))

- one more conversion option in a stile quest - synonym in barrier type quest Synonym may cause users to agonize over selecting exactly equivalent options. But will also reduce confusion when encountering a pedestrian gate and considering it as different from a vehicle gate. fixes streetcomplete#3188

add pedestrian gate answer in barrier quests

…walk quest (fixes streetcomplete#2542)

Sort building type by recently used frequency

Using a sequence here doesn't really make sense, but it will in the next commit when I remove LinkedList entirely

thefeiter and others added 30 commits October 3, 2021 01:32

Add Fire Hydrant Dimaeter Quest

f59ec67

center text

2e08b31

making custom hydrant sign

b9582fa

Finalize quest

def1d6f

Fix deletion of AddFireHydrantType module

48d6943

Add country restriction

cd8b268

Rescale and reroute paths

9a47f11

split into image and textedit

b6d3957

adjust elementFilter

079df13

add plausibility check

a166f79

add Quest for Belgium

0d311bf

Add uk variant

85d6c2b

Add night version of images for nicer fade to background

8a12a46

Add version for Poland

ff6bb53

Yellow sign also available in Ireland

cb12403

Add default Quest Layout for other countries

3e299e9

revert added translations

139f516

remove newline

9783256

Add Finland Sign

e1974bf

Signs optimized for "DE","BE","GB","PL","IE","FI"

5b1ed83

Pre-select first entry in history sidebar

8595b47

Undoing the most recent entry in the history is probably the most common action, so we'd like it to be faster. This removes a tap by pre-selecting the first entry when the sidebar is first opened.

add support for concrete:plates and concrete:lanes

5f0da95

fixes streetcomplete#2437

stop trying to be overly clever

31a2ceb

'Concrete lanes' not 'Concrete without full cover'

Change to modulo 5 for value check

6bcba30

Change to modulo 5 for value check, add netherlands sign, improve nic…

582f0f8

…ht mode fade out colors

adjust text color

6d5cb2c

Adjust quests question. Add "no sign" option.

d73477f

delete old file

3ce0ffd

westnordost added 2 commits October 18, 2021 22:35

rename function

da5ea4a

fix common ANR through database access on main thread

6da0377

# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/data/quest/QuestAutoSyncer.kt

smichel17 force-pushed the favs-refactor branch 2 times, most recently from 82de9eb to 4057a50 Compare October 19, 2021 14:57

matkoniecz and others added 23 commits October 19, 2021 17:18

translator credits tasks also needs the PHPSESSID now

127c0c8

use the correct kerb image

e03698e

update changelog

c061511

Merge pull request streetcomplete#3409 from matkoniecz/gate

c745aee

add pedestrian gate answer in barrier quests

Merge branch 'master' of https://github.com/westnordost/StreetComplete

d94fec8

update changelog

79744f3

update changelog

c6c631e

remove unused imports

5e557f1

optimize a few SVGs

88272ad

fix / suppress a few lint warnings

c20e32b

update dependencies

9145dcf

use FragmentContainerView instead of fragment

5820b40

remove a few unused strings

7e395fb

remove another unused string

d0f60ea

update translations

f14e2cc

fix compilation

451335e

update boundaries.ser (add Kosovo country-code "XK")

2e6c531

Remember and offer to apply the last answer for the cycleway and side…

f2895c6

…walk quest (fixes streetcomplete#2542)

Merge pull request streetcomplete#3373 from smichel17/house-sort

d4e7a78

Sort building type by recently used frequency

Replace favs LinkedList with regular list

d76568e

Using a sequence here doesn't really make sense, but it will in the next commit when I remove LinkedList entirely

Replace LastUsedValuesStore LinkedList with Sequence

7d2450b

Further simplify LastUsedValues::add

201935e

smichel17 force-pushed the favs-refactor branch from 4057a50 to 201935e Compare October 21, 2021 21:35

smichel17 closed this Nov 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor LastUsedValuesStore to use sequences instead of LinkedList #3

Refactor LastUsedValuesStore to use sequences instead of LinkedList #3

smichel17 commented Oct 18, 2021 •

edited

Loading

smichel17 commented Oct 19, 2021

Refactor LastUsedValuesStore to use sequences instead of LinkedList #3

Refactor LastUsedValuesStore to use sequences instead of LinkedList #3

Conversation

smichel17 commented Oct 18, 2021 • edited Loading

smichel17 commented Oct 19, 2021

smichel17 commented Oct 18, 2021 •

edited

Loading