Improve path handling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smikula
added a commit
that referenced
this pull request
Nov 8, 2017
The previous path handling changes (#14) end up leaking the `NormalizedPath` type. Consumers should be allowed to just pass simple strings in for those paths. This change introduces a new `NormalizedOptions` type that is used for options internally, separate from the `Options` object the consumer passes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
NormalizedPathtype. It's just an alias forstring, but uses a trick to simulate nominal typing. (See Microsoft/Typescript #202 for details.) Any instance ofNormalizedPathis guaranteed to be normalized because it can only be created by a call tonormalizePath. Any variables that contain paths throughout the code have been updated to use this type.This also includes a minor fix to normalize the drive letter to upper-case in Windows paths.