Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load fences #99

Conversation

Adjective-Object
Copy link
Collaborator

Adds a config manager to lazy load fences on request

This does not functionally affect a full fence check, it's only useful in partial fence checks. This is for scenarios where we only need to check against a subset of fences (e.g. there are import changes with no fence changes, and we only need to check the fences of the importer and imported files)

src/utils/loadConfig.ts Outdated Show resolved Hide resolved
Copy link
Owner

@smikula smikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments.

@Adjective-Object
Copy link
Collaborator Author

There's no reason .all needs to be a property access as opposed to a getter function so I'm going to update it to getAllConfigs() for consistency.

@smikula smikula merged commit 6e9cc52 into smikula:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants