-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load fences #99
Merged
smikula
merged 5 commits into
smikula:master
from
Adjective-Object:u/mahuangh/faster-source-providers-5-lazy-load-configs
Aug 11, 2021
Merged
Lazy load fences #99
smikula
merged 5 commits into
smikula:master
from
Adjective-Object:u/mahuangh/faster-source-providers-5-lazy-load-configs
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smikula
reviewed
Aug 10, 2021
smikula
reviewed
Aug 10, 2021
smikula
reviewed
Aug 10, 2021
smikula
reviewed
Aug 10, 2021
smikula
requested changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments.
There's no reason .all needs to be a property access as opposed to a getter function so I'm going to update it to getAllConfigs() for consistency. |
smikula
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config manager to lazy load fences on request
This does not functionally affect a full fence check, it's only useful in partial fence checks. This is for scenarios where we only need to check against a subset of fences (e.g. there are import changes with no fence changes, and we only need to check the fences of the importer and imported files)